fix: resolve Next.js hydration mismatches for browser APIs#1390
Open
Abhishek2005-ard wants to merge 9 commits into
Open
fix: resolve Next.js hydration mismatches for browser APIs#1390Abhishek2005-ard wants to merge 9 commits into
Abhishek2005-ard wants to merge 9 commits into
Conversation
|
@Abhishek2005-ard is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @Abhishek2005-ard!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @Abhishek2005-ardBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves two React Hydration Mismatch errors that were triggering the Next.js error overlay in development.
The mismatches occurred because the application was directly evaluating browser-specific APIs (
localStorageandnavigator.platform) during the initial render cycle. Because these APIs either do not exist or evaluate differently during Server-Side Rendering (SSR), the server-rendered HTML did not match the initial client hydration payload.Changes Made
useVideoEditor.ts: Refactored thesoundOnCompletioninitialization. It now initializes cleanly to its default value and uses auseEffectto safely read and apply the user's saved preference fromlocalStoragepost-hydration.VideoEditor.tsx: Converted theisMacconstant into a state variable and moved thenavigator.platformcheck into auseEffecthook to prevent text node mismatches between"Ctrl" + Enter(server) and"⌘" + Enter(Mac client).Testing Instructions
npm run devto start the Next.js development server."⌘" + Enterafter the initial page load.close #1387