fix: ratio field overflow in custom frame preset panel#1401
Open
anksingh1212121 wants to merge 1 commit into
Open
fix: ratio field overflow in custom frame preset panel#1401anksingh1212121 wants to merge 1 commit into
anksingh1212121 wants to merge 1 commit into
Conversation
|
@anksingh1212121 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @anksingh1212121Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @anksingh1212121!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:intermediate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When clicking the Custom preset in the frame selector, the Ratio field overflowed its container. The custom dimensions panel used a single non-wrapping
flexrow, so the ratio label (e.g.Landscape (16:9)) had no room and clipped outside the panel.Fixed by:
flex flex-col gap-3so Width/Height and Ratio stack verticallygrid grid-cols-[1fr_auto_1fr]so they always stay on the same linew-fullso it spans the full width below the inputsRelated Issue
Closes #1399
Type of Contribution
Participant Info
after the fix:
