feat: add interactive export frame preview#1404
Open
saurabhhhcodes wants to merge 1 commit into
Open
Conversation
|
Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @saurabhhhcodes!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @saurabhhhcodesBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Author
|
Validation update: local checks are green on commit 66e34fc. Passing locally:
The only red GitHub status I can see is Vercel authorization required for the maintainer project. Also, this PR closes assigned issue #391, which has gssoc:approved plus feature/design labels; please mirror the GSSoC scoring label if accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #391
Adds a live export-frame preview so the editor shows the selected output aspect ratio before export instead of only drawing crop guide bars over a 16:9 player. Fill mode now supports horizontal and vertical crop-position sliders, and those values are passed into the FFmpeg crop expression so preview and export stay aligned.
Also fixes the local Vitest harness so the existing at-sign import alias and localStorage-dependent tests run reliably.
Type of Change
How Has This Been Tested?
Checklist:
Screenshots (if applicable)
No static screenshot attached yet; the local app is running and ready for visual proof if requested.