fix: remove duplicate main landmarks and id='main-content' across pages#1410
Open
mayurigade-hub wants to merge 1 commit into
Open
fix: remove duplicate main landmarks and id='main-content' across pages#1410mayurigade-hub wants to merge 1 commit into
mayurigade-hub wants to merge 1 commit into
Conversation
- layout.tsx: single <main id='main-content'> wraps all children (no change) - page.tsx: removed duplicate <main id='main-content'> wrapper around VideoEditor - privacy/page.tsx: changed <main> to <div> to avoid nested main landmarks - contact/page.tsx: changed <main> to <div> to avoid nested main landmarks Fixes duplicate id='main-content' and nested <main> accessibility issues.
|
@mayurigade-hub is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @mayurigade-hub!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @mayurigade-hubBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
github-actions
Bot
added
level:beginner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes duplicate
id="main-content"values and nested<main>landmark elements that caused invalid HTML and accessibility issues for screen readers and keyboard users.Root Cause
layout.tsxalready renders a single:that wraps all page content.
However,
page.tsx,privacy/page.tsx, andcontact/page.tsxwere also rendering their own<main>elements, resulting in:id="main-content"on the homepage<main>landmarks across pagesChanges Made
src/app/layout.tsx— No changes required; remains the single source of truth for<main id="main-content">src/app/page.tsx— Removed the duplicate<main id="main-content">wrapper around<VideoEditor />src/app/privacy/page.tsx— Replaced<main>with<div>src/app/contact/page.tsx— Replaced<main>with<div>Result
id="main-content"exists per page<main>landmark exists per pageRelated Issue
Closes #1264
Type of Contribution
Participant Info
GitHub Username: mayurigade-hub
Contribution Level: Intermediate
Screen Recording
Not required. This is a structural accessibility fix with no visual UI changes.
Verification can be done through browser DevTools by confirming:
id="main-content"exists<main>landmark exists per pageChecklist
bun run lintpassesbunx tsc --noEmitpassesconsole.logstatements remain