Skip to content

fix: add roving tabindex and radiogroup aria pattern to RotateControl#1412

Open
aarushivyas-15 wants to merge 3 commits into
magic-peach:mainfrom
aarushivyas-15:fix-issue-#157
Open

fix: add roving tabindex and radiogroup aria pattern to RotateControl#1412
aarushivyas-15 wants to merge 3 commits into
magic-peach:mainfrom
aarushivyas-15:fix-issue-#157

Conversation

@aarushivyas-15
Copy link
Copy Markdown

Description

Implemented roving tabindex and radiogroup ARIA pattern for RotateControl buttons.

  • Wrapped rotation buttons in role="radiogroup" container
  • Changed individual buttons to role="radio" with aria-checked
  • Added keyboard navigation with ArrowLeft/ArrowRight keys
  • Added tabIndex fallback when no rotation is selected

Related Issue

Fixes #157

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • GSSoC contribution

Participant Info

  • GitHub username: aarushivyas-15
  • Contribution level (Beginner/Intermediate/Advanced): Beginner

loom link : https://www.loom.com/share/1f86a51e5fef49d2b54002a000278f05

Recording / Loom link: ## Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2026

@aarushivyas-15 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @aarushivyas-15!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 30, 2026

✅ PR Format Check Passed — @aarushivyas-15

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added gssoc'26 GirlScript Summer of Code 2026 level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor labels May 30, 2026
@aarushivyas-15 aarushivyas-15 changed the title Fix issue #157 fix: add roving tabindex and radiogroup aria pattern to RotateControl May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Accessibility] Add roving tabindex to rotation button group

1 participant