fix: add roving tabindex and radiogroup aria pattern to RotateControl#1412
Open
aarushivyas-15 wants to merge 3 commits into
Open
fix: add roving tabindex and radiogroup aria pattern to RotateControl#1412aarushivyas-15 wants to merge 3 commits into
aarushivyas-15 wants to merge 3 commits into
Conversation
|
@aarushivyas-15 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @aarushivyas-15!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @aarushivyas-15Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented roving tabindex and radiogroup ARIA pattern for RotateControl buttons.
role="radiogroup"containerrole="radio"witharia-checkedRelated Issue
Fixes #157
Type of Contribution
Participant Info
loom link : https://www.loom.com/share/1f86a51e5fef49d2b54002a000278f05
Recording / Loom link: ## Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in