fix: remove nested main element causing hydration mismatch#1415
Open
Kokila-chandrakar wants to merge 1 commit into
Open
fix: remove nested main element causing hydration mismatch#1415Kokila-chandrakar wants to merge 1 commit into
Kokila-chandrakar wants to merge 1 commit into
Conversation
|
@Kokila-chandrakar is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @Kokila-chandrakarBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
github-actions
Bot
added
level:beginner
Contributor
👋 Thanks for your PR, @Kokila-chandrakar!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Author
|
Hi @magic-peach , I’ve submitted a fix for the hydration mismatch issue by removing the redundant nested Could someone please review this PR and let me know if any changes are needed? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed the redundant
element fromsrc/app/page.tsx.Changes
<main id="main-content">wrapper from the Home page.<main>element provided bysrc/app/layout.tsx.Why
Having nested
<main>elements creates invalid HTML structure and can contribute to React hydration inconsistencies between server-rendered and client-rendered markup.Result
close #1397