Skip to content

fix: replace invalid FFmpeg fontweight param with bold=1 and fix fontfile set to name instead of path #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhinav-atul wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −7
Open

fix: replace invalid FFmpeg fontweight param with bold=1 and fix fontfile set to name instead of path #1416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/lib/text-overlay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,16 +89,19 @@ export function buildTextFilter(
const fontFileParam = getFFmpegFontArg(overlay.fontFamily, overlay.fontPath);

// Build the drawtext filter with font support
let filter = `drawtext=text='${escapedText}':x=${pixelX}:y=${pixelY}:fontsize=${overlay.fontSize}:fontcolor=${overlay.color}:fontweight=${fontWeightParam}`;
let filter = `drawtext=text='${escapedText}':x=${pixelX}:y=${pixelY}:fontsize=${overlay.fontSize}:fontcolor=${overlay.color}`;

// Add font family if specified
if (overlay.fontFamily) {
// Sanitize font name for FFmpeg
const safeFontName = overlay.fontFamily.replace(/[^a-zA-Z0-9-]/g, "");
filter += `:fontfile='${safeFontName}'`;
// Add bold flag only when font weight is bold (fontweight= is not a valid FFmpeg option)
if (fontWeightParam === "bold") {
filter += `:bold=1`;
}

// For system fonts (no custom fontfile), use font= with the family name
// For custom fonts, use only the fontfile= path from getFFmpegFontArg
if (overlay.fontFamily && !fontFileParam) {
filter += `:font='${overlay.fontFamily}'`;
}

// Add custom font file path if available
if (fontFileParam) {
filter += `:${fontFileParam}`;
}
Expand Down
Loading