Skip to content

fix: correct main heading hierarchy#1417

Open
saurabhhhcodes wants to merge 1 commit into
magic-peach:mainfrom
saurabhhhcodes:fix/heading-hierarchy-69
Open

fix: correct main heading hierarchy#1417
saurabhhhcodes wants to merge 1 commit into
magic-peach:mainfrom
saurabhhhcodes:fix/heading-hierarchy-69

Conversation

@saurabhhhcodes
Copy link
Copy Markdown

Closes #69

Summary

  • keep the sticky header brand text visually unchanged without rendering a second page-level h1
  • promote reusable editor section labels from h3 to h2 so the main page follows h1 -> h2 order
  • verified the app shell, home page, and video editor now expose one h1 and no skipped heading level in the targeted files

Validation

  • npx tsc --noEmit --pretty false
  • npm run lint -- --file src/app/layout.tsx --file src/app/page.tsx --file src/components/VideoEditor.tsx
  • npm run build
  • git diff --check

Note: dependency install required npm install --legacy-peer-deps because the repo currently has a React 19 / @testing-library/react 14 peer dependency conflict under plain npm install. No dependency or lockfile changes are included.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2026

Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:testing Testing labels May 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @saurabhhhcodes

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @saurabhhhcodes!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue] Fix heading hierarchy in the main page

1 participant