feat: add undo toast for Reset all settings button#687
Conversation
|
@vdadheech is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
👋 Thanks for your PR, @vdadheech!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
✅ PR Format Check Passed — @vdadheechBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
|
Hey @vdadheech! CI hasn't run on this PR yet. Please rebase on git fetch origin
git rebase origin/main
git push --force-with-leaseAlso please attach a screen recording showing your change working at |
|
Hey @vdadheech! This PR has merge conflicts with git fetch origin
git rebase origin/main
# resolve any conflicts
git push --force-with-leaseOnce rebased and CI (build/lint/typecheck) passes, the undo toast feature will be reviewed. Thanks! |
|
Hey @vdadheech! The undo toast pattern for the reset button is a clever UX idea (Gmail-style snackbar). However, there are blockers:
To fix:
Once these are fixed, the feature can be properly reviewed. |
Saves a snapshot of current settings before reset and shows a 5-second undo toast. Clicking Undo restores the previous state. Follows the Gmail-style 'snackbar undo' pattern instead of a blocking confirm dialog. Closes #<issue-number>
3136036 to
a9b475f
Compare
|
#687 closed |
Saves a snapshot of current settings before reset and shows a 5-second undo toast. Clicking Undo restores the previous state. Follows the Gmail-style 'snackbar undo' pattern instead of a blocking confirm dialog.
Closes #
Description
Related Issue
Type of Contribution
Participant Info
Checklist