fix: prevent trim end input from stripping decimal points while typing#907
Open
Nightcoder-26 wants to merge 1 commit into
Open
fix: prevent trim end input from stripping decimal points while typing#907Nightcoder-26 wants to merge 1 commit into
Nightcoder-26 wants to merge 1 commit into
Conversation
The Trim End input field previously bound its value directly to 'recipe.trimEnd'. Because 'trimEnd' is stored as a parsed float, typing a decimal point (e.g. '1.') caused the trailing decimal to be immediately stripped by parseFloat during the change handler, making it impossible to type decimal values manually. Fix: Introduce a local 'endInput' state variable for the Trim End input, mirroring the existing architecture used for 'startInput'. This acts as an intermediary text state, allowing users to type decimals naturally while keeping the underlying recipe state synchronized.
|
Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @Nightcoder-26Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @Nightcoder-26!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:beginner
Author
|
@magic-peach kindly review the PR and merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where typing a decimal point in the Trim End input field would immediately strip the decimal, making it impossible to type values like 1.5 manually.
Previously, the Trim End input field bound its value directly to recipe.trimEnd. Because trimEnd is stored as a parsed float, typing a decimal point (e.g., 1.) caused the trailing decimal to be immediately stripped by parseFloat during the React re-render.
Fix: Introduced a local endInput state variable for the Trim End input, mirroring the existing architecture used for the startInput field. This acts as an intermediary text state, allowing users to type decimals naturally while keeping the underlying recipe state synchronized.
Related Issue
fixes #904
Type of Contribution
Participant Info
Screen Recording
Recording.2026-05-22.125056.mov
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in