fix: reset to default button audio slider#919
Open
aryanm9026 wants to merge 3 commits into
Open
Conversation
|
@aryanm9026 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @aryanm9026Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @aryanm9026!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the Cumulative Layout Shift (CLS) and UI jitter in the
AudioSpeedControlcomponent.h-10space for the "Reset to Default" button so it no longer pushes elements down when it appears.duration-300) with a slight delay (delay-200) so the button eases in smoothly rather than snapping instantly when sliding fast.localSpeedIndex) from the heavy FFmpeg parent update (onChange). The slider now updates locally on drag for buttery smooth movement, and only triggers the heavy parent state update on release (onPointerUp) and keyboard navigation (onKeyUp).Related Issue
Closes #759
Type of Contribution
Participant Info
Screen Recording
Screen.Recording.2026-05-22.150008.mp4
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in