Skip to content

feat: add accessible tooltips to all editor controls#927

Open
jaygaikar-09 wants to merge 2 commits into
magic-peach:mainfrom
jaygaikar-09:feat/editor-tooltips
Open

feat: add accessible tooltips to all editor controls#927
jaygaikar-09 wants to merge 2 commits into
magic-peach:mainfrom
jaygaikar-09:feat/editor-tooltips

Conversation

@jaygaikar-09
Copy link
Copy Markdown
Contributor

Description

Added accessible tooltips to all editor controls to improve usability and onboarding for first-time users.

Implemented a lightweight reusable Tooltip component with support for:

  • hover interactions
  • keyboard focus accessibility
  • long-press support on touch devices

Tooltips now explain editor settings, constraints, and quality/performance tradeoffs directly within the UI.


Related Issue

Closes #662


Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • GSSoC contribution

Participant Info

  • GitHub username: jaygaikar-09
  • Contribution level (Beginner/Intermediate/Advanced): Beginner

Screen Recording

https://drive.google.com/file/d/1URaKXA5jJSKD3mJXFgqqGfXiChYD8zy8/view?usp=sharing


Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

Summary of Changes

Added

  • src/components/ui/Tooltip.tsx
    • Reusable lightweight tooltip component
    • Hover, focus, and long-press support
    • Accessible role="tooltip" implementation

Updated Components

  • PresetSelector.tsx
  • FramingControl.tsx
  • TrimControl.tsx
  • RotateControl.tsx
  • AudioSpeedControl.tsx
  • ExportSettings.tsx
  • FormatSelector.tsx
  • VideoEditor.tsx

Accessibility Improvements

  • Added aria-describedby support
  • Keyboard-accessible focus tooltips
  • Screen-reader compatible tooltip content
  • Touch-device long-press support
  • Removed redundant title attributes where appropriate

UX Improvements

  • Clear contextual explanations for all editor controls
  • Better discoverability for advanced settings
  • Improved onboarding for new users
  • No additional dependencies introduced

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@jaygaikar-09 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:performance Performance labels May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @jaygaikar-09!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

✅ PR Format Check Passed — @jaygaikar-09

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added the gssoc'26 GirlScript Summer of Code 2026 label May 22, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:performance Performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: tooltips on all editor controls — explain what each setting does on hover

1 participant