Skip to content

feat: theme toggle#932

Open
Palakchoithani wants to merge 9 commits into
magic-peach:mainfrom
Palakchoithani:feat/theme-toggle
Open

feat: theme toggle#932
Palakchoithani wants to merge 9 commits into
magic-peach:mainfrom
Palakchoithani:feat/theme-toggle

Conversation

@Palakchoithani
Copy link
Copy Markdown
Contributor

Description

Added theme-related UI support and persistence behavior, improved export readability in dark mode and high-contrast mode, fixed the onboarding tour crash, and cleaned up lint/typecheck issues in the branch.

Related Issue

Closes #928

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • GSSoC contribution

Participant Info

  • GitHub username: Palakchoithani
  • Contribution level (Beginner/Intermediate/Advanced): Intermediate

Screen Recording

596754167-e9c370fa-7463-4f8c-b949-6ed6cc0090ef.mov

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

Copilot AI review requested due to automatic review settings May 22, 2026 12:34
@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Palakchoithani!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added the level:advanced Advanced level - 55 pts label May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

✅ PR Format Check Passed — @Palakchoithani

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature gssoc'26 GirlScript Summer of Code 2026 labels May 22, 2026
@Palakchoithani
Copy link
Copy Markdown
Contributor Author

This PR adds theme support and improves accessibility across the export flow.

What changed:

  • Added theme toggle support with persistence.
  • Improved export UI readability in dark mode.
  • Fixed export button visibility in high-contrast mode.
  • Softened the high-contrast export button color so it is easier on the eyes.
  • Fixed the onboarding tour crash caused by a missing step position.
  • Cleaned up lint and TypeScript issues, including warning-prone image usage and a missing keyboard shortcut dependency.

Validation:

  • bun run lint passes
  • bunx tsc --noEmit passes

Thanks for reviewing.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Palakchoithani Palakchoithani changed the title Feat/theme toggle feat: theme toggle May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(export): make export button readable in high-contrast mode

2 participants