fix: use a single hidden file input#942
Open
satyamtiwari-1499 wants to merge 2 commits into
Open
Conversation
Contributor
✅ PR Format Check Passed — @satyamtiwari-1499Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @satyamtiwari-1499!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
|
@satyamtiwari-1499 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
/gssoc26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #940
This PR fixes duplicate hidden file input elements inside the
FileUploadcomponent.Previously, multiple hidden
<input type="file">elements were rendered across different UI states while sharing the sameinputRef. This could cause the ref to point to an unexpected input instance, resulting in inconsistent file picker behavior and redundant DOM elements.This contribution is submitted as part of GSSoC'26 open source contribution.
Changes Made
inputRefonly onceonChangehandlersResult
The
Changebutton, dropzone click, and keyboard shortcuts likeCtrl/Cmd + Onow consistently open the same file picker with predictable ref behavior and cleaner DOM structure.Testing
bun run dev