Skip to content

fix: add missing dependencies to handleExport useCallback#948

Open
Hastiv01 wants to merge 1 commit into
magic-peach:mainfrom
Hastiv01:fix/handleExport-dependencies
Open

fix: add missing dependencies to handleExport useCallback#948
Hastiv01 wants to merge 1 commit into
magic-peach:mainfrom
Hastiv01:fix/handleExport-dependencies

Conversation

@Hastiv01
Copy link
Copy Markdown
Contributor

Description

Fixed the handleExport function by adding missing dependencies to the useCallback dependency array in src/hooks/useVideoEditor.ts.

Previously, some updated audio settings like music file, volume, and loop option were not always applied during export because the latest values were not being used.

Changes made:
-Added missing dependencies to the handleExport hook
-Ensured updated audio and overlay settings are correctly used during export

Related Issue

Closes #787

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • GSSoC contribution

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@Hastiv01 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Hastiv01!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions
Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @Hastiv01

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature labels May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Missing dependencies in useCallback causing stale state in handleExpo

1 participant