Skip to content

Fix: Prevent premature state update and export corruption in TrimControl #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magic-peach merged 3 commits into from
May 23, 2026
+5 −4
Merged

Fix: Prevent premature state update and export corruption in TrimControl #957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77378cd
Fix premature state update in TrimControl
Sandeep6135 May 22, 2026
552742b
Trigger CI recheck
Sandeep6135 May 22, 2026
f74a76c
Fix unexportable video bug for unknown durations
Sandeep6135 May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/TrimControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,6 @@ export default function TrimControl({ recipe, onChange, duration, file }: Props)

const n = parseFloat(val);

onChange({ trimEnd: n });

if (isNaN(n)) {
setEnd(true);
setEndErrorMsg("Enter a valid number.");
Expand Down Expand Up @@ -112,6 +110,7 @@ export default function TrimControl({ recipe, onChange, duration, file }: Props)

setEnd(false);
setEndErrorMsg("");
onChange({ trimEnd: n });
};

const inputClass =
Expand Down
6 changes: 4 additions & 2 deletions src/hooks/useVideoEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,13 @@ function validateRecipe(recipe: EditRecipe, duration: number ): string | null {
"Trim start time cannot be less than 0 seconds.",
],
[
recipe.trimEnd !== null && recipe.trimEnd > duration,
recipe.trimEnd !== null && duration > 0 && recipe.trimEnd > duration,
`Trim end time cannot exceed the video duration (${Math.floor(duration)}s).`,
],
[
recipe.trimStart >= (recipe.trimEnd ?? duration),
recipe.trimEnd !== null
? recipe.trimStart >= recipe.trimEnd
: (duration > 0 && recipe.trimStart >= duration),
"Trim start time must be earlier than the end time.",
],
[
Expand Down
Loading