Fix: Allow exporting of videos with unknown duration (e.g. streaming WebM)#958
Merged
magic-peach merged 1 commit intoMay 23, 2026
Merged
Conversation
|
@Sandeep6135 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @Sandeep6135Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @Sandeep6135!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@magic-peach I have starred the repo already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a critical bug where videos missing duration metadata (such as streaming WebM blobs where
video.durationisInfinity) were completely blocked from being exported.The Problem:
When
extractMetadataencountered a video withInfinityduration, it correctly fell back to setting the duration to0. However, the validation checks inuseVideoEditor.tsrigidly enforced thattrimStart(default0) must be earlier than the duration. This caused0 >= 0to evaluate totrue, instantly failing the validation and throwing a "Trim start time must be earlier than the end time" error, making these videos completely unexportable.The Solution:
Updated the validation logic in
useVideoEditor.tsto smartly bypass the duration constraint whenduration === 0(meaning it's unknown/missing metadata).trimEnd, we still rigidly enforcetrimStart < trimEnd.trimEndis null anddurationis missing, we safely allow the export to proceed to FFmpeg without failing the pre-flight checks.Testing:
Closes #955.