Skip to content

feat: add page-level drag-and-drop overlay for video upload#980

Merged
magic-peach merged 2 commits into
magic-peach:mainfrom
sudha09-git:feat/project-completion-tracker
May 23, 2026
Merged

feat: add page-level drag-and-drop overlay for video upload#980
magic-peach merged 2 commits into
magic-peach:mainfrom
sudha09-git:feat/project-completion-tracker

Conversation

@sudha09-git
Copy link
Copy Markdown
Contributor

@sudha09-git sudha09-git commented May 22, 2026

Description

Adds a full-screen drag-and-drop overlay that appears when a user drags a video file anywhere on the page — not just inside the upload zone. Previously, dragging outside the upload zone had no visual feedback.

Related Issue

Closes #5

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • GSSoC contribution

Participant Info

  • GitHub username: sudha09-git
  • Contribution level: Intermediate

Changes Made

  • Added document-level dragenter, dragleave, dragover, drop event listeners
  • Full-screen dark overlay with animated pulsing ring appears when dragging over the page
  • Used dragCounterRef to prevent overlay flicker caused by nested elements
  • Added aria-live and aria-label for screen reader accessibility
  • Non-video file drops show a clear error message
  • Existing drop zone behaviour unchanged

How to Test

  1. Open the app
  2. Drag any video file from your file explorer over the browser window
  3. A full-screen dark overlay with animated ring appears ✅
  4. Drop anywhere to upload ✅
  5. Dropping a non-video file shows error: "Please drop a valid video file" ✅

Screen Recording

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@sudha09-git is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

✅ PR Format Check Passed — @sudha09-git

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:advanced Advanced level - 55 pts type:bug Bug fix type:docs Documentation type:feature New feature type:testing Testing labels May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @sudha09-git!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added the gssoc'26 GirlScript Summer of Code 2026 label May 22, 2026
@sudha09-git
Copy link
Copy Markdown
Contributor Author

Hi @magic-peach

I've implemented the page-level drag-and-drop overlay feature as discussed in the issue.

What was done:

  • Added document-level dragenter, dragleave, dragover, and drop event listeners
  • Full-screen overlay with animated pulsing ring appears when dragging a file anywhere on the page
  • Used dragCounterRef to prevent flickering caused by nested DOM elements
  • Non-video file drops show a clear error message
  • Added aria-live and aria-label for accessibility
  • All existing functionality remains unchanged

Tested on:

  • Dragging video file anywhere on page ✅
  • Dropping non-video file shows error ✅
  • Existing click-to-upload still works ✅
  • Ctrl+O shortcut still works ✅

Please let me know if any changes are needed. Happy to update!

@sudha09-git
Copy link
Copy Markdown
Contributor Author

/pr

@sudha09-git
Copy link
Copy Markdown
Contributor Author

/PR approval

@sudha09-git
Copy link
Copy Markdown
Contributor Author

Important

please tell me is it approved or not??

@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
reframe Ready Ready Preview, Comment May 23, 2026 11:00am

@magic-peach magic-peach added gssoc:approved Approved for GSSoC'26 quality:clean Well-implemented, clean code labels May 23, 2026
@magic-peach magic-peach merged commit d844d93 into magic-peach:main May 23, 2026
12 of 13 checks passed
@magic-peach
Copy link
Copy Markdown
Owner

@sudha09-git please star the repo

chavanGaneshDatta pushed a commit to chavanGaneshDatta/reframe that referenced this pull request May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved Approved for GSSoC'26 gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts quality:clean Well-implemented, clean code type:bug Bug fix type:docs Documentation type:feature New feature type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Memory Leak Problem in URL.

2 participants