Skip to content

feat: add tooltip to disabled Export button (#983)#984

Merged
magic-peach merged 1 commit into
magic-peach:mainfrom
Pranav-IIITM:feat/export-button-tooltip
May 23, 2026
Merged

feat: add tooltip to disabled Export button (#983)#984
magic-peach merged 1 commit into
magic-peach:mainfrom
Pranav-IIITM:feat/export-button-tooltip

Conversation

@Pranav-IIITM
Copy link
Copy Markdown
Contributor

Description

When no video is uploaded, the Export button now shows a native browser tooltip ("Upload a video to enable export") on hover via a conditional title prop. The tooltip is removed once a video is loaded. No extra JS, state, or dependencies added — single prop change in VideoEditor.tsx.


Related Issue

Closes #983


Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • GSSoC contribution

Participant Info

  • GitHub username: @Pranav-IIITM
  • Contribution level: Intermediate

Screen Recording

feat_add.tooltip.to.disabled.Export.button.1.mp4

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

magic-peach#983)

When no video is uploaded, the Export button now shows a native browser
tooltip — "Upload a video to enable export" — on hover. Tooltip is
removed once a video is loaded. No extra JS or dependencies added.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

@Pranav-IIITM is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature labels May 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Pranav-IIITM!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions
Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @Pranav-IIITM

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added the gssoc'26 GirlScript Summer of Code 2026 label May 23, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
reframe Ready Ready Preview, Comment May 23, 2026 10:56am

@magic-peach magic-peach added gssoc:approved Approved for GSSoC'26 quality:clean Well-implemented, clean code labels May 23, 2026
@magic-peach magic-peach merged commit 6feee99 into magic-peach:main May 23, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved Approved for GSSoC'26 gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts quality:clean Well-implemented, clean code type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add tooltip message to Export button explaining why it is disabled

2 participants