Skip to content

Fix IPA generated by ipatool not installable via itms-services #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anjiuzhe wants to merge 3 commits into from
+4 −4
Closed

Fix IPA generated by ipatool not installable via itms-services #434

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
694cf7c
fix: generate ipa compatible with itms-services installation
anjiuzhe Jan 16, 2026
eb0ae39
Merge branch 'main' into fix/itms-services-install
majd Feb 16, 2026
a9670bf
Merge branch 'main' into fix/itms-services-install
majd Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/appstore/appstore_replicate_sinf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,16 +135,16 @@ func (t *appstore) replicateSinfFromInfo(info packageInfo, zip *zip.Writer, sinf

func (t *appstore) replicateZip(src *zip.ReadCloser, dst *zip.Writer) error {
for _, file := range src.File {
srcFile, err := file.OpenRaw()
srcFile, err := file.Open()
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Close opened zip entry readers

replicateZip now uses file.Open(), which returns an io.ReadCloser, but the returned reader is never closed in the loop. On IPAs with many entries (or repeated calls via both ReplicateSinf and applyPatches), this leaves decompressor resources alive until GC and can cause avoidable memory growth/resource pressure; close srcFile after each copy (including error paths).

Useful? React with 👍 / 👎.

if err != nil {
return fmt.Errorf("failed to open raw file: %w", err)
return fmt.Errorf("failed to open file: %w", err)
}

header := file.FileHeader
dstFile, err := dst.CreateRaw(&header)
dstFile, err := dst.CreateHeader(&header)

if err != nil {
return fmt.Errorf("failed to create raw file: %w", err)
return fmt.Errorf("failed to create file: %w", err)
}

_, err = io.Copy(dstFile, srcFile)
Expand Down