Skip to content

Fix IPA generated by ipatool not installable via itms-services #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
majd merged 2 commits into from
Apr 16, 2026
Merged

Fix IPA generated by ipatool not installable via itms-services #469

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d9ee30
fix: generate ipa compatible with itms-services installation
anjiuzhe Jan 16, 2026
07a426f
Close zip entry readers during replication
majd Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions pkg/appstore/appstore_replicate_sinf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,21 +135,29 @@ func (t *appstore) replicateSinfFromInfo(info packageInfo, zip *zip.Writer, sinf

func (t *appstore) replicateZip(src *zip.ReadCloser, dst *zip.Writer) error {
for _, file := range src.File {
srcFile, err := file.OpenRaw()
if err != nil {
return fmt.Errorf("failed to open raw file: %w", err)
}
err := func() error {
srcFile, err := file.Open()
if err != nil {
return fmt.Errorf("failed to open file: %w", err)
}
defer srcFile.Close()

header := file.FileHeader
dstFile, err := dst.CreateRaw(&header)
header := file.FileHeader
dstFile, err := dst.CreateHeader(&header)

if err != nil {
return fmt.Errorf("failed to create raw file: %w", err)
}
if err != nil {
return fmt.Errorf("failed to create file: %w", err)
}

_, err = io.Copy(dstFile, srcFile)
if err != nil {
return fmt.Errorf("failed to copy file: %w", err)
}

_, err = io.Copy(dstFile, srcFile)
return nil
}()
if err != nil {
return fmt.Errorf("failed to copy file: %w", err)
return err
}
}

Expand Down
Loading