Skip to content

test(deps): skip transient failures in github URL reachability test #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpup merged 1 commit into from
Apr 27, 2026
Merged

test(deps): skip transient failures in github URL reachability test #344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions internal/deps/registry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,9 @@ func TestRegistryGithubBinaryPlaceholders(t *testing.T) {

// TestRegistryGithubBinaryURLsExist validates that all github-binary download URLs
// are reachable. This catches version/asset naming errors before e2e tests.
// Skipped by default; run with: go test -run TestRegistryGithubBinaryURLsExist -urls
// Skipped in short mode. Transient network errors and 5xx responses skip the
// individual subtest rather than failing — only 404/410 (which indicate a
// genuinely wrong asset URL) are reported as failures.
func TestRegistryGithubBinaryURLsExist(t *testing.T) {
if testing.Short() {
t.Skip("Skipping URL validation in short mode")
Expand Down Expand Up @@ -270,13 +272,16 @@ func TestRegistryGithubBinaryURLsExist(t *testing.T) {

resp, err := client.Do(req)
if err != nil {
t.Fatalf("failed to reach %s: %v", url, err)
t.Skipf("transient network error reaching %s: %v", url, err)
}
defer resp.Body.Close()

if resp.StatusCode == http.StatusNotFound {
t.Errorf("URL returns 404: %s", url)
} else if resp.StatusCode >= 400 {
switch {
case resp.StatusCode == http.StatusNotFound, resp.StatusCode == http.StatusGone:
t.Errorf("URL returns %d (asset missing): %s", resp.StatusCode, url)
case resp.StatusCode >= 500:
t.Skipf("transient %d from %s", resp.StatusCode, url)
case resp.StatusCode >= 400:
t.Errorf("URL returns %d: %s", resp.StatusCode, url)
}
})
Expand Down
Loading