Merged
Conversation
…ders Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds list_itdashboard_investments and get_itdashboard_investment for the /api/itdashboard/ resource, including the ITDashboardInvestment model, ShapeConfig defaults, schema registration, and conformance entries. Filter coverage mirrors the API's tier-gated filterset (search; agency_code/type_of_investment/updated_time range; agency_name/cio_rating/ cio_rating_max/performance_risk) with explicit named params and proper bool/date serialization. Tests: - 4 unit tests covering default shape, filter forwarding, get-by-uii, and funding(*) / cio_evaluation(*) expansions - 14 integration tests with recorded cassettes covering shape variants, pagination, every filter, and dict + list-of-dict expansions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_itdashboard_investmentsandget_itdashboard_investmentfor the/api/itdashboard/resource (ITDashboardInvestmentmodel,ShapeConfig.ITDASHBOARD_INVESTMENTS_MINIMAL/_COMPREHENSIVE, schema registration, conformance entry).bool→"true"/"false"anddate/datetime→ ISO serialization:searchagency_code,type_of_investment,updated_time_after/updated_time_beforeagency_name,cio_rating,cio_rating_max,performance_riskfunding(*)dict expansion,cio_evaluation(*)list-of-dict expansion).Test plan
pytest tests/test_client.py tests/test_models.py tests/test_shapes.py— 215 unit tests passpytest tests/integration/test_itdashboard_integration.py— 14 cassette-replay tests pass in <1spytest tests/full suite — 361 passed, 2 skipped (pre-existing)scripts/check_filter_shape_conformance.py --manifest …/filter_shape_contract.json) — 0 errorsvcr_config)https://tango.makegov.com/api/itdashboard/succeeded with a business+ keyNotes
../tangofilter manifest does not yet enumerateitdashboardunderresources, so the conformance script can't validate filter-param parity for itdashboard against the manifest. That's a tango-side regen, not an SDK fix.uv.lockmodification (a 0.4.3 → 0.4.4 version bump) was intentionally left out of this PR — it predates this work.🤖 Generated with Claude Code