geoprobe: create sockets on-demand instead of holding them open per target#3378
Draft
geoprobe: create sockets on-demand instead of holding them open per target#3378
Conversation
…pen 2 sockets per target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
probeTarget()during each measurement cyclecreateSenderPair()andprobeTarget()helpers to consolidate duplicated probe logic fromprobeWorkerandMeasureOnesenderFactoryfunction type for test injection, replacing directsenderEntrystruct manipulation in testsDiff Breakdown
Net code reduction; the core change simplifies the pinger by removing persistent socket management.
Key files (click to expand)
controlplane/telemetry/internal/geoprobe/pinger.go— replacedsenders map[string]*senderEntrywithtargets map[string]ProbeAddress; addedcreateSenderPair()andprobeTarget()for on-demand socket lifecycle; simplifiedClose()to just clear the target mapcontrolplane/telemetry/internal/geoprobe/pinger_test.go— switched tests from injectingsenderEntrystructs to using amockFactoryforsenderFactory; updated all assertions fromsenderstotargetsTesting Verification
senderFactoryinjection pattern; all existing test scenarios (dual-probe min RTT, one-fails-uses-other, both-fail, concurrent add/remove, MeasureOne) preserved