[Snyk] Security upgrade glob from 10.4.5 to 10.5.0#37
Closed
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-GLOB-14040952
3 tasks
Owner
Author
|
Superseded by #48 (MAN8-7226) which upgrades to glob@12.0.0 and resolves all 5 Snyk high-severity findings instead of just the direct-glob one. |
man8
added a commit
that referenced
this pull request
Apr 15, 2026
## Summary Upgrades `glob` from 10.4.5 → **12\.0.0** to resolve 5 high-severity Snyk findings reachable via assetmill's dependency tree. Linear: [MAN8-7226](https://linear.app/man8/issue/MAN8-7226/assetmill-upgrade-glob-to-12x-snyk-fixes-5-high-severity-issues) Snyk project: https://app.snyk.io/org/man8/project/06db0e24-92a7-4385-93f2-4d01ae449811 ## CVEs / findings fixed | Sev | Issue | CWE | In | CVSS | | --- | --- | --- | --- | --- | | High | Inefficient Algorithmic Complexity | CWE-407 | minimatch@9.0.5 | 8\.7 | | High | Regular Expression Denial of Service (ReDoS) | CWE-1333 | minimatch@9.0.5 | 8\.7 | | High | Regular Expression Denial of Service (ReDoS) | CWE-1333 | minimatch@9.0.5 | 8\.7 | | High | Command Injection | CWE-78 | glob (direct) | 7\.7 | | High | Infinite loop | CWE-835 | brace-expansion@2.0.2 | 7\.1 | ## Breaking change: Node engine bump glob@12 requires Node.js **≥20.17.0** (drops Node 18). `engines.node` in `package.json` has been bumped from `>=18.0.0` → `>=20.17.0` to match. Consumers still on Node 18 will need to upgrade. ## Caller impact Only one direct call site: `src/utils/file-utils.ts` uses the named `glob` export with `{ cwd, absolute: true }` options — fully API-compatible across v10 → v11 → v12. No code changes required. ## Verification - `npm run ci` green locally — build + 73 tests pass + lint clean - `npm audit` high-vuln count dropped by the 5 findings listed above Supersedes #37 (which only proposed glob@10.5.0 and would not have cleared the Snyk findings). ## Test plan - [x] `npm run ci` passes locally - [x] GitHub Actions CI passes - [x] Snyk re-scan shows 0 remaining glob-chain vulns 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **Chores** - Updated minimum Node.js runtime requirement to version 20.17.0 or higher. - Upgraded dependency versions to ensure improved compatibility and performance. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
package.jsonpackage-lock.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-GLOB-14040952
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Command Injection
Note
Upgrade
globto^10.5.0and updatepackage-lock.jsonaccordingly.Written by Cursor Bugbot for commit e9dd316. This will update automatically on new commits. Configure here.