This repository was archived by the owner on Oct 15, 2025. It is now read-only.
Support for Unicode ASN Names and option to include accuracy radius in distance calculation#6
Open
sck-nogas wants to merge 2 commits intomandiant:masterfrom
Open
Support for Unicode ASN Names and option to include accuracy radius in distance calculation#6sck-nogas wants to merge 2 commits intomandiant:masterfrom
sck-nogas wants to merge 2 commits intomandiant:masterfrom
Conversation
Contributor
|
Thank you for identifying the Unicode issue, I've updated Version 1.01 to support Unicode ASNs. Please let me know if you have any additional questions. Also, thanks for sharing the radius of accuracy information. I didn't know that existed but it seems extremely useful. I'll test out your pull request and hopefully get the feature included shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's two quick fixes that I uncovered.
1 - The ASN names if they include Unicode like "TELEFÔNICA BRASIL S.A" would cause the program to crash since in Python2 str can't handle unicode.
2 - When calculating the distance between two location, sometimes the IP location is "approximate", and in some of my logs, the MaxMind DB was putting the location as (37.751, -97.822) which is in the middle of Cheney Reservoir outside, Wichita Kansas. When in reality the actual location was closer to Emeryville, CA. When looking into this issue, I noticed that for some IP address, MaxMind has a 1,000km accuracy radius. Therefore, to prevent over alerting, I included an option to take the accuracy into account.