core: malformed cade should stop cascading#17
Open
atagen wants to merge 6 commits into
Open
Conversation
atagen
force-pushed
the
fix/malformed-cade-caps-cascade
branch
from
2c9a7fb to
32e89ad
Compare
atagen
force-pushed
the
fix/malformed-cade-caps-cascade
branch
from
32e89ad to
9678f47
Compare
atagen
force-pushed
the
fix/malformed-cade-caps-cascade
branch
from
9678f47 to
5aeb5d5
Compare
When walking the ancestor chain, a `.cade` that fails to parse now caps the cascade at that dir instead of being silently climbed past to a valid parent. This keeps the chain-shape decision aligned with activation, which re-reads the same file via `config_keywords` and surfaces the parse error there: without the cap, chain construction would build a shape that quietly ignored a broken `.cade`, then activation would fail (or compose a parent the user never expected) on the very same file. The cap reuses the single per-dir parse already performed for `disinherit` detection (`caps_the_cascade`), so no extra read is introduced. Behavior is identical to disinherit's cap: the malformed dir itself still joins as the chain root (its error surfaces at load), and gap-fill anchors on it without ever reaching above. Split out of the disinherit feature commit so this policy change lands with its own rationale and tests.
atagen
force-pushed
the
fix/malformed-cade-caps-cascade
branch
from
5aeb5d5 to
5a853e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.