resolver: introduce tack-on-tack overrides#17
Merged
Merged
Conversation
Contributor
Author
|
it has been pointed out to me that this PR kinda sucks, and I agree. putting this on the backburner for now |
Contributor
Author
|
it sucks less now |
atagen
force-pushed
the
tack-follows
branch
3 times, most recently
from
db1edab to
a05efc8
Compare
amaanq
force-pushed
the
tack-follows
branch
3 times, most recently
from
8eae061 to
0a4a840
Compare
amaanq
previously approved these changes
May 31, 2026
Co-authored-by: Amaan Qureshi <git@amaanq.com>
amaanq
approved these changes
May 31, 2026
atagen
commented
May 31, 2026
|
|
||
| rootNode = if upLock != null then upLock.root else null; | ||
| callerInputs = mkCallerInputs upLock rootNode (raw.inputs or { }) combined_follows all_follow_rules; | ||
| mkCallerInputs = |
Contributor
Author
There was a problem hiding this comment.
flag this for a refactor in future, hard af to read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #14 as best we can