Conversation
atagen
force-pushed
the
refactor
branch
2 times, most recently
from
a40a44a to
59c8968
Compare
atagen
force-pushed
the
refactor
branch
2 times, most recently
from
f73e589 to
2fa05bb
Compare
port the gitlab compare backend dropped during the refactor re-linearisation (reslice-folded c0eaf68): merge_base via the v4 api classifies a moving gitlab ref as ahead/behind/diverged instead of the git2 ls-remote identical-or-nothing. split the Source::Gitlab arm of current_rev_compared out of the generic git path; the git2 ls-remote stays the rev backend, the api is comparison-only and refines only a resolved moving ref. add env-token (GITLAB_TOKEN, sent as PRIVATE-TOKEN) and gitlab_json to the http client; nix.conf token scraping is left for a later commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is big, but completely guts out the spaghetti prototyping-like code we'd written up until this point and actually structrues the code in a cohesive manner. this will also help a lot w/ maintainability in the future