This repository was archived by the owner on Jan 12, 2024. It is now read-only.
lib/carto/mml.js: FIX: Error: Function yaml.safeLoad is removed in js…#514
Open
josch wants to merge 1 commit intomapbox:masterfrom
Open
lib/carto/mml.js: FIX: Error: Function yaml.safeLoad is removed in js…#514josch wants to merge 1 commit intomapbox:masterfrom
josch wants to merge 1 commit intomapbox:masterfrom
Conversation
…-yaml 4. Use yaml.load instead, which is now safe by default.
Contributor
|
This PR, as it currently stands, would be using the unsafe |
Author
Yes. I'll leave it up to you to make the switch. I'm just forwarding a patch that I apply to the Debian package of carto because in Debian we can only ship one version of each package, so we have carto use the latest version of js-yaml which is 4.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-yaml 4. Use yaml.load instead, which is now safe by default.
This makes the code compatible with js-yaml >= 4.