Fix corner case when clipped line ends have low simplification factor#99
Open
VladyslavOdobesku-TomTom wants to merge 1 commit intomapbox:masterfrom
Conversation
simplification factor thus important parts of a line can be dropped in the last step of conversion to vector tile.
Author
|
@mourner maybe you can review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title is quite self-explanatory. I've seen this code in
simplify.hppwhere simplification factor is enforced to be 1.0 for initial projected line ends, however, when the line is clipped into pieces there is no mechanism to also ensure that ends of clipped lines are not dropped.
We've found this bug in the wild only in 2 lines so far. The fix works for us as we've patched it on our end. It was suggested to also raise a PR into upstream library.