This repository was archived by the owner on May 28, 2021. It is now read-only.
Support React 16#33
Open
vicapow wants to merge 5 commits intomapbox:masterfrom
Open
Conversation
Author
|
bump :) |
Author
|
cc: @jfirebaugh ? |
Author
|
sorry for being annoying. is this project abandoned? |
Author
|
I'm willing to maintain this project, if that helps |
|
Thank you for your patience @vicapow! We'll get you a code review this week. |
Fix keybindingsOnInputs property
|
Hi @vicapow, thank you for your pull request and for your patience. I checked in with the team about a review, and after discussion, we decided that the best way forward is to rewrite this project from the ground up to better accommodate additional internal use cases. My suggestion would be to use your forked HOC for now until we are able to release a new package that's compatible with React 16. @kepta should be opening an issue soon to start the revision discussion. Please let us know if you have any questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.