Iaejean custom http session#120
Open
iaejean wants to merge 2 commits intomarcelog:masterfrom
iaejean:iaejean_custom_http_session
Open
Iaejean custom http session#120iaejean wants to merge 2 commits intomarcelog:masterfrom iaejean:iaejean_custom_http_session
iaejean wants to merge 2 commits intomarcelog:masterfrom
iaejean:iaejean_custom_http_session
Conversation
Owner
There was a problem hiding this comment.
Where is this exception thrown? Doesn't seem to be used at all
Owner
|
The pull looks great :) I'll try to make some final tests. If you take care of the comments that I just wrote, we're ready to merge :) Thanks man! |
Owner
There was a problem hiding this comment.
This method is still defined as static in HttpSession... are you sure you ran the tests and they pass?
Owner
|
Tests don't pass for me. Check the comments. And also, for example for the tests in Test_HttpFrontController the session bean is missing. Please check that all the tests pass, and let me know. I'm still interested in merging :) Good luck! Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your advice and apologize for the delay but I also sent the changes and tests, greetings and I am waiting for your comments.