Engine: Ensure Engine produces valid Ruby in test suite#1207
Merged
Conversation
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
marcoroth
force-pushed
the
engine-valid-ruby
branch
from
49c0697 to
e59bf8c
Compare
marcoroth
force-pushed
the
engine-valid-ruby
branch
from
e59bf8c to
ad2e8b8
Compare
Co-Authored-By: Julián Pinzón Eslava <julian@buildkite.com>
marcoroth
force-pushed
the
engine-valid-ruby
branch
from
ad2e8b8 to
4fe1d2b
Compare
This was referenced Feb 19, 2026
marcoroth
added a commit
to marcoroth/reactionview
that referenced
this pull request
Feb 19, 2026
Inspired by #78 (comment) Follow up on marcoroth/herb#1207 Follow up on marcoroth/herb#1209
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by marcoroth/reactionview#78 (comment)
This pull request updates our
assert_compiled_snapshotassertion helper to make sure the compiled snapshot is valid Ruby by passing the engine output to Prism and checking for syntax errors.