Skip to content

Engine: Ensure assert_evaluated_snapshot produces valid Ruby in tests #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoroth merged 1 commit into from
Feb 19, 2026
+14 −0
Merged

Engine: Ensure assert_evaluated_snapshot produces valid Ruby in tests #1209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions test/snapshot_utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,25 @@ def assert_compiled_snapshot(source, options = {}, **kwargs)

def assert_evaluated_snapshot(source, locals = {}, options = {}, **kwargs)
require_relative "../lib/herb/engine"
require "prism"

enforce_erubi_equality = kwargs.delete(:enforce_erubi_equality) || false
engine_options = options.merge(kwargs)

engine = Herb::Engine.new(source, engine_options)

prism_result = Prism.parse(engine.src)
syntax_errors = prism_result.errors.reject { |e| e.type == :invalid_yield }

assert syntax_errors.empty?, <<~MESSAGE
Compiled output is not valid Ruby:

#{syntax_errors.map { |e| " - #{e.message} (line #{e.location.start_line})" }.join("\n")}

Compiled source:
#{engine.src}
MESSAGE

binding_context = Object.new

locals.each do |key, value|
Expand Down
Loading