Engine: Fix newline handling after heredoc terminators#1246
Merged
Conversation
5401428 to
39ff6a3
Compare
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes newline handling after heredoc terminators in ERB tags. When compiling an
ERBContentNodecontaining a heredoc, the compiled Ruby could end up with syntactically invalid Ruby in two specific cases:When the tag was at the start of a line,
apply_trimappended" \n"(space + newline) as trailing whitespace after the code, which placed a trailing space on the heredoc terminator line. Ruby doesn't recognize a heredoc terminator with trailing whitespace characters.For the following snippet (from Engine: Herb builds invalid ruby when HEREDOC is present #1245):
The engine now produces:
__herb = ::Herb::Engine; _buf = ::String.new; text = <<~TEXT Hello, world! - TEXT + TEXT _buf.to_sWhen the tag was not at the start of a line (inline),
add_codeappended;instead of\nafter the code, placing a semicolon directly after the heredoc terminator and thus altering the heredoc terminator.For the following snippet:
The engine now produces:
__herb = ::Herb::Engine; _buf = ::String.new; _buf << '<div>'.freeze; text = <<~TEXT Hello, world! - TEXT; _buf << '</div> + TEXT + _buf << '</div> '.freeze; _buf.to_sRelated #1206
Resolves #1245