Parser: Lazily allocate hb_array_T for AST_NODE->errors#1425
Draft
Parser: Lazily allocate hb_array_T for AST_NODE->errors#1425
hb_array_T for AST_NODE->errors#1425Conversation
f6027dd to
a11cea0
Compare
a11cea0 to
406f72c
Compare
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, every AST node allocated an
hb_array_Twith a capacity of 8 for itserrorsarray upfront, even on the happy path where no errors ever occur. This wasted 96 bytes per node (32 bytes for thehb_array_Tstruct + 64 bytes for the items buffer).This pull request introduces
hb_array_append_lazy, which skips the allocation entirely until the first error is actually appended. Allappend_*_errorfunctions now takehb_array_T**and use lazy initialization. Parser locals are initialized asNULLinstead ofhb_array_init(8, ...).I measured it against
app/views/wrapped/index.html.erbin RubyEvents, which is the view that uses up the most memory in that app.On current main
eda3aa0using./herb parse ../rubyevents/app/views/wrapped/index.html.erbCompared to this pull request:
I think this is kind of nice improvement for just changing the way error arrays are initialized. There is probably more we can do in the same realm.
Resolves #1343
Related: #1381