Engine: Preserve line count for multi-line code blocks#1556
Open
joelhawksley wants to merge 6 commits intomarcoroth:mainfrom
Open
Engine: Preserve line count for multi-line code blocks#1556joelhawksley wants to merge 6 commits intomarcoroth:mainfrom
joelhawksley wants to merge 6 commits intomarcoroth:mainfrom
Conversation
Multi-line `<% ... %>` code blocks where `<%` and `%>` are on their own lines lose line count parity with Erubi. The `.strip` call on `node.content.value` removes the leading/trailing newlines that represent the `<%` and `%>` delimiter lines. Erubi processes templates line-by-line and naturally emits blank lines for standalone `<%` and `%>` delimiters. Herb processes the entire ERBContentNode as one chunk. Fix: Detect when raw content starts/ends with newlines (indicating standalone delimiters) and preserve them in the emitted code. Also adjust `apply_trim` to use `right_space = "\n"` when code already ends with a newline, avoiding double-newline emission.
Contributor
Author
|
Moving back to draft mode while I re-validate against |
marcoroth
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-line
<% ... %>code blocks where<%and%>are on their own lines lose line count parity with Erubi. The.stripcall onnode.content.valueremoves the leading/trailing newlines that represent the delimiter lines.Erubi processes templates line-by-line and naturally emits blank lines for standalone
<%and%>delimiters. Herb processes the entire ERBContentNode as one chunk and strips these.Fix: Detect when raw content starts/ends with newlines (indicating standalone delimiters) and preserve them. Adjust
apply_trimto useright_space = "\n"when code already ends with a newline to avoid double-newline emission.