Formatter: Fix trailing whitespace in <pre> with inline child elements#1571
Open
hakanensari wants to merge 1 commit intomarcoroth:mainfrom
Open
Formatter: Fix trailing whitespace in <pre> with inline child elements#1571hakanensari wants to merge 1 commit intomarcoroth:mainfrom
<pre> with inline child elements#1571hakanensari wants to merge 1 commit intomarcoroth:mainfrom
Conversation
When an inline element (e.g. `<code>`, `<span>`) inside `<pre>` is
nested within a parent element and the line exceeds `maxLineLength`,
`visitHTMLCloseTagNode` incorrectly adds indentation before the close
tag. Inside `capture().join("")`, this indentation becomes trailing
spaces that grow on each format pass.
Check `inContentPreservingContext` so close tags are always appended
inline when inside content-preserving elements.
There was a problem hiding this comment.
Pull request overview
Fixes a formatter idempotency regression affecting content-preserving tags after the Herb upgrade, where nested <pre><code>…</code></pre> could accumulate trailing whitespace on repeated formatting passes.
Changes:
- Added a regression test ensuring
<pre>with an inline child element exceedingmaxLineLengthremains unchanged and idempotent across runs. - Updated close-tag printing logic to append closing tags to the current line when inside a content-preserving context, preventing indentation/trailing-space injection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javascript/packages/formatter/test/html/content-preserving-tags.test.ts | Adds a failing regression test for <div><pre><code>… idempotency when line length is exceeded. |
| javascript/packages/formatter/src/format-printer.ts | Ensures close tags are appended inline while in content-preserving contexts to avoid introducing trailing whitespace. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading to the latest Herb version, formatting
<pre><code>blocks nested inside another element became non-idempotent.Each formatter run appends trailing whitespace before the closing tag, which then triggers lint errors.
I added a failing test.