Parser: Introduce RubyParameterNode and support block arguments#1585
Merged
Parser: Introduce RubyParameterNode and support block arguments#1585
RubyParameterNode and support block arguments#1585Conversation
5f86ec9 to
9cab8d2
Compare
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
9cab8d2 to
457cc70
Compare
0c210a0 to
5b628ae
Compare
5b628ae to
7bf60b9
Compare
7bf60b9 to
642d0a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds block argument extraction to both
ERBBlockNodeandERBRenderNode, refactors the render node structure, and unifies parameter representation across the parser.We renamed
RubyStrictLocalNode→RubyParameterNodeto we can reuase the existing nodes from the strict locals for bothERBBlockNodeandERBRenderNode.Now shared by both strict locals and block arguments. Added
keyword,splat, andblockbooleans to distinguish all parameter types:Follow up on #1583