Skip to content

Linter: Allow Turbo helpers in erb-no-unused-expressions #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoroth merged 1 commit into from
Apr 2, 2026
Merged

Linter: Allow Turbo helpers in erb-no-unused-expressions #1586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions javascript/packages/linter/src/rules/erb-no-unused-expressions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ const SIDE_EFFECT_METHODS = new Set([
"content_for",
"provide",
"flush",
"turbo_refreshes_with",
"turbo_exempts_page_from_cache",
"turbo_exempts_page_from_preview",
"turbo_page_requires_reload",
])

class UnusedExpressionCollector extends PrismVisitor {
Expand Down
9 changes: 9 additions & 0 deletions javascript/packages/linter/test/rules/erb-no-unused-expressions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,15 @@ describe("ERBNoUnusedExpressionsRule", () => {
`)
})

test("passes for Turbo helpers", () => {
expectNoOffenses(dedent`
<% turbo_refreshes_with method: :morph, scroll: :preserve %>
<% turbo_exempts_page_from_cache %>
<% turbo_exempts_page_from_preview %>
<% turbo_page_requires_reload %>
`)
})

test("passes for ERB comments", () => {
expectNoOffenses(dedent`
<%# This is a comment %>
Expand Down
Loading