Parser: Support ternaries with transform_conditionals option#1594
Merged
Parser: Support ternaries with transform_conditionals option#1594
transform_conditionals option#1594Conversation
transform_conditionals to support ternaries
43a44cf to
f0163c1
Compare
transform_conditionals to support ternariestransform_conditionals option
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request extends
transform_conditionalsto handle ternary expressions (condition ? 'yes' : 'no') in ERB output tags, transforming them intoERBIfNode/ERBElseNodestructures.The following:
is transformed to the equivalent with
transform_conditionals: true:This also works inside attribute values, open tags, and nested within postfix conditionals:
becomes:
The ternary transform is split into its own file (
ternary_conditionals.c) separate from the postfix conditional transform (postfix_conditionals.c). Thetransform_ternary_expressionfunction is exported so thatpostfix_conditionals.ccan call it when a nested ternary is detected inside a postfix body.Follows up on #1560 which added postfix support and intentionally named the option
transform_conditionalsto allow for this extension.A future optimization could be to extract literal values directly as
LiteralNodes or the proper equivalent. So that:could become: