Skip to content

Ensure Herb Handler produces valid Ruby in snapshot tests #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoroth merged 2 commits into from
Feb 19, 2026
Merged

Ensure Herb Handler produces valid Ruby in snapshot tests #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d910023
Ensure `Herb::Engine` produces valid Ruby in snapshot tests
marcoroth Feb 19, 2026
1fc84a1
RuboCop
marcoroth Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion test/snapshot_utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
require "readline"
require "digest"
require "json"
require "prism"

def ask?(prompt = "")
Readline.readline("===> #{prompt}? (y/N) ", true).squeeze(" ").strip == "y"
Expand All @@ -25,6 +26,18 @@ def assert_compiled_snapshot(source, handler: ReActionView::Template::Handlers::

compiled_source = template.handler.call(template, source)

prism_result = Prism.parse(compiled_source)
syntax_errors = prism_result.errors.reject { |e| e.type == :invalid_yield }

assert syntax_errors.empty?, <<~MESSAGE
Compiled output is not valid Ruby:

#{syntax_errors.map { |e| " - #{e.message} (line #{e.location.start_line})" }.join("\n")}

Compiled source:
#{compiled_source}
MESSAGE

snapshot_key = JSON.generate({
source: source,
handler: handler,
Expand All @@ -39,7 +52,7 @@ def assert_compiled_snapshot(source, handler: ReActionView::Template::Handlers::
compiled_source
end

def assert_evaluated_snapshot(source, ivars: {}, options: {}, handler: ReActionView::Template::Handlers::ERB, virtual_path: "test", format: :html, locals: []) # rubocop:disable Metrics/ParameterLists,Layout/LineLength
def assert_evaluated_snapshot(source, ivars: {}, options: {}, handler: ReActionView::Template::Handlers::ERB, virtual_path: "test", format: :html, locals: []) # rubocop:disable Metrics/ParameterLists,Layout/LineLength,Metrics/MethodLength
template = ActionView::Template.new(
source,
"test_template",
Expand All @@ -51,6 +64,18 @@ def assert_evaluated_snapshot(source, ivars: {}, options: {}, handler: ReActionV

compiled_source = template.handler.call(template, source)

prism_result = Prism.parse(compiled_source)
syntax_errors = prism_result.errors.reject { |e| e.type == :invalid_yield }

assert syntax_errors.empty?, <<~MESSAGE
Compiled output is not valid Ruby:

#{syntax_errors.map { |e| " - #{e.message} (line #{e.location.start_line})" }.join("\n")}

Compiled source:
#{compiled_source}
MESSAGE

lookup_context = ActionView::LookupContext.new([])
view_context = ActionView::Base.with_empty_template_cache.new(lookup_context, {}, nil)

Expand Down