[pull] master from opnsense:master#1270
Open
pull[bot] wants to merge 4000 commits intomarcushoff:masterfrom
Open
[pull] master from opnsense:master#1270pull[bot] wants to merge 4000 commits intomarcushoff:masterfrom
pull[bot] wants to merge 4000 commits intomarcushoff:masterfrom
Conversation
AdSchellevis
force-pushed
the
master
branch
3 times, most recently
from
272532c to
43a1743
Compare
fichtner
force-pushed
the
master
branch
2 times, most recently
from
89d5c6b to
f5ae0c8
Compare
AdSchellevis
force-pushed
the
master
branch
2 times, most recently
from
709906d to
bc2ca23
Compare
AdSchellevis
force-pushed
the
master
branch
5 times, most recently
from
3d71277 to
20a8006
Compare
AdSchellevis
force-pushed
the
master
branch
6 times, most recently
from
78845fc to
8ba454a
Compare
AdSchellevis
force-pushed
the
master
branch
2 times, most recently
from
810ecdc to
897d3cc
Compare
…lter_var(..,FILTER_VALIDATE_EMAIL) might align more with RFC's, but since RFC 5322 accepts almost everything, might not be the best option in reality.
… have changed the configuration (group modification), closes #10255
…10258) Align implementation with get_real_interface() except that we shall not give a fallback of $device = $interface since we want better integrity in MVC code (and don't deal with devices in configuration data there).
… have changed the configuration (group modification), closes #10255 [part 2] Missed the fact that $config and $userindex should be globals here due to legacy reasons and missed the index_users() call which is also used in diag_authentication.php
…l ip's, which sometimes collisions with our standard handling when it comes to "nonsync" behavior. In f469cf8 we fixed virtual ips with a vhid set, but missed the point that the backup may also set nosync on an item not in the list at all, in which case these items that are not in the list will still be duplicated. This commit removes the vhid constraint and ignore all "nosync" records, which should close the gap here.
This is a fringe use case, but it's better to do this here than to handroll upcoming changes in the ipsec connections page.
Co-authored-by: Stephan de Wit <stephan.de.wit@deciso.com>
Introduce the base apply button to the page and improve UX and UI: 1. Local/remote now show ID 2. Tabbed dialog with cancel button and better save/cancel placement 3. Better grid spacing in tabbed dialog 4. Apply now closes the tabbed dialog, but save does not 5. Avoid grid flapping in tabbed dialog Co-authored-by: Stephan de Wit <stephan.de.wit@deciso.com> Discussed-with: @Monviech
It's no longer required since the static PHP pages are gone and config_read_array() doesn't need it either.
A major change for later. Luckily only Kea ever (almost) used this.
PR: #7592 Co-authored-by: @bgilesmca
This reverts commit 7c8bda9. This didn't add any value. But keep the explode->getValues transformation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )