fix: normalize backslashes in markdown image paths on Windows#9174
Draft
fix: normalize backslashes in markdown image paths on Windows#9174
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Markdown image rendering on Windows by normalizing Windows-style backslashes in saved image paths to URL-friendly forward slashes.
Changes:
- Normalize
savedFilePathbackslashes (\) to forward slashes (/) before inserting the Markdown image link. - Add a unit test to ensure Windows-style paths are converted to forward-slash paths in the inserted Markdown.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/core/codemirror/markdown/commands.ts | Normalizes saved image paths to forward slashes so Markdown image URLs work on Windows. |
| frontend/src/core/codemirror/markdown/tests/commands.test.ts | Adds coverage for Windows-style path normalization behavior in insertImage. |
Bundle ReportChanges will decrease total bundle size by 24.1kB (-0.1%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: marimo-esmAssets Changed:
Files in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9159