Skip to content

MLE-26427 More Polaris fixes #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjrudin merged 1 commit into from
Jan 16, 2026
Merged

MLE-26427 More Polaris fixes #1882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...nt-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,9 @@ protected final DocumentWriteSet filterDocuments(Context context, Function<Strin

private String serializeContent(DocumentWriteOperation doc) {
String content = HandleAccessor.contentAsString(doc.getContent());
if (content == null) {
return null;
}

Format format = null;
if (doc.getContent() instanceof BaseHandle<?, ?> baseHandle) {
Expand Down
10 changes: 4 additions & 6 deletions marklogic-client-api/src/main/java/com/marklogic/client/impl/OkHttpServices.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5627,14 +5627,12 @@ private void executeRequest(CallResponseImpl responseImpl) {
};

Response response = sendRequestWithRetry(requestBldr, sendRequestFunction, resendableConsumer);

Objects.requireNonNull(response);
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Objects.requireNonNull() call should include a descriptive error message as the second parameter to help with debugging if the response is unexpectedly null. For example: Objects.requireNonNull(response, \"Response from sendRequestWithRetry cannot be null\").

Suggested change
Objects.requireNonNull(response);
Objects.requireNonNull(response, "Response from sendRequestWithRetry cannot be null");

Copilot uses AI. Check for mistakes.
if (session != null) {
List<ClientCookie> cookies = new ArrayList<>();
if (response != null) {
for (String setCookie : response.headers(HEADER_SET_COOKIE)) {
ClientCookie cookie = parseClientCookie(requestBldr.build().url(), setCookie);
cookies.add(cookie);
}
for (String setCookie : response.headers(HEADER_SET_COOKIE)) {
ClientCookie cookie = parseClientCookie(requestBldr.build().url(), setCookie);
cookies.add(cookie);
}
((SessionStateImpl) session).setCookies(cookies);
}
Expand Down