MLE-25585 implement optic transitive closure in java client. #1883
+625
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
stevebio
force-pushed
the
feature/25585-add-optic-transitiveClosure
branch
3 times, most recently
from
c816ac2 to
635d244
Compare
rjrudin
previously approved these changes
Jan 20, 2026
Contributor
rjrudin
left a comment
rjrudin
left a comment
There was a problem hiding this comment.
Looks good to me, I just noted some things that can be deleted and some warnings that IntelliJ flagged.
marklogic-client-api/src/main/java/com/marklogic/client/expression/PlanBuilder.java
Show resolved
Hide resolved
marklogic-client-api/src/main/java/com/marklogic/client/impl/PlanBuilderImpl.java
Outdated
Show resolved
Hide resolved
| * A sequence of options for transitive closure operations | ||
| * in a row pipeline. | ||
| */ | ||
| public interface PlanTransitiveClosureOptionsSeq { |
Contributor
There was a problem hiding this comment.
This looks like it can be deleted, not needed by the user.
Author
There was a problem hiding this comment.
Will test then delete, think you're right.
test-app/src/main/ml-data/optic/transitive-closure/transClosureTripleSet.xml
Show resolved
Hide resolved
...ogic-client-api/src/test/java/com/marklogic/client/test/rows/OpticTransitiveClosureTest.java
Show resolved
Hide resolved
...ogic-client-api/src/test/java/com/marklogic/client/test/rows/OpticTransitiveClosureTest.java
Outdated
Show resolved
Hide resolved
stevebio
force-pushed
the
feature/25585-add-optic-transitiveClosure
branch
2 times, most recently
from
d1b05d9 to
975d7ea
Compare
Add generated code with minor changes. Add tests for op.transitiveClosure. Add triple data for tests. Some copyright header fixes.
stevebio
force-pushed
the
feature/25585-add-optic-transitiveClosure
branch
from
975d7ea to
4705ad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation of optic transitiveClosure function in marklogic java client api.
Add triple data for tests.
Add xdmp generated code with minor changes.
Add tests for op.transitiveClosure.