MLE-26427 Couple more tests for incremental write #1888
Merged
+53
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just verifying that text / binary work as expected. Also improved an existing test to use a different hash field name.
There was a problem hiding this comment.
Pull request overview
This PR adds test coverage for incremental write functionality with text and binary documents, and updates an existing test to use a custom hash field name.
Changes:
- Added a new field index configuration for "myWriteHash" in the database configuration
- Updated the
customTimestampKeyNametest to verify the custom hash field name and ensure default hash key is not present - Added two new tests to verify incremental write behavior for text and binary documents
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test-app/src/main/ml-config/databases/content-database.json | Added field index configuration for custom "myWriteHash" field to support the updated test |
| marklogic-client-api/src/test/java/com/marklogic/client/datamovement/filter/IncrementalWriteTest.java | Consolidated imports, improved existing test assertions, and added new tests for text and binary document handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
BillFarber
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just verifying that text / binary work as expected. Also improved an existing test to use a different hash field name.