fix: restore main build — multi-source []string in protocol verify test#50
Merged
Conversation
PR #49 was authored against a stale local main and merged before the build matrix finished, breaking main: origin/main had already refactored VerifyConfig.Source to []string (multi-source), so the protocol regression's `Source: "go"` no longer type-checks (go vet/test fail to compile internal/engine). Use `Source: []string{"go"}` to match the current API. Behavior unchanged — TestVerifyProtocolScenarioJoins still asserts the protocol scenario joins (no dangling), passes, and locks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incident: main is red
PR #49 was authored against a stale local
mainand auto-merged before the build matrix finished. Currentmainhad already refactoredVerifyConfig.Sourcefromstring→[]string(multi-source, #48 line). The protocol regression test merged withSource: "go", which no longer type-checks against[]string— sogo vet/go testfail to compileinternal/engineonmain:Fix
One line:
Source: "go"→Source: []string{"go"}, matching every other test in the file. No behavior change —TestVerifyProtocolScenarioJoinsstill asserts the protocol scenario joins (noDangling), passes, and locks. TheCarriesScenarios() = !k.Singular()fix from #49 is already on main and unaffected.Verification
mise run cigreen against the mergedmain(fmt, build, vet,go test ./...— fresh, uncached). Protocol regression passes against the multi-source API.