Incorrect component reported in warning when filename contains dots.#3
Open
boughtonp wants to merge 1 commit intomarkmandel:developfrom
Open
Incorrect component reported in warning when filename contains dots.#3boughtonp wants to merge 1 commit intomarkmandel:developfrom
boughtonp wants to merge 1 commit intomarkmandel:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ColdDoc falls over on CFCs with dots in their filename, but reports the incorrect component path when logging this error.
e.g. for
/path/to/object.archive.cfcthe log would reportpath.to.objectas not existing.It's possible ColdDoc should report a different error (e.g. invalid cfc filename), but as a quick fix, simply removing the
.cfcfrom the end of the filename results in a more obvious error message.